fix Iridescence name #2489
fix Iridescence name #2489
Conversation
WalkthroughThe pull request modifies the Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev/1.4 #2489 +/- ##
===========================================
- Coverage 68.91% 68.90% -0.02%
===========================================
Files 923 923
Lines 96043 96007 -36
Branches 8134 8141 +7
===========================================
- Hits 66189 66149 -40
- Misses 29601 29604 +3
- Partials 253 254 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (3)
packages/shader-shaderlab/src/shaders/shadingPBR/BRDF.glslis excluded by!**/*.glslpackages/shader-shaderlab/src/shaders/shadingPBR/FragmentPBR.glslis excluded by!**/*.glslpackages/shader-shaderlab/src/shaders/shadingPBR/LightIndirectPBR.glslis excluded by!**/*.glsl
📒 Files selected for processing (1)
packages/core/src/material/PBRMaterial.ts(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: build (22.x, windows-latest)
- GitHub Check: e2e (22.x)
- GitHub Check: codecov
🔇 Additional comments (1)
packages/core/src/material/PBRMaterial.ts (1)
489-490: LGTM! Fixed the iridescence bug.The implementation correctly clones both
iridescenceThicknessRangeandiorproperties, which were previously missing. This fixes the iridescence bug by ensuring these properties are properly copied during material cloning.Let's verify the property types and default values are consistent:
✅ Verification successful
Property types and defaults are consistent
The implementation correctly handles both properties:
- IOR is properly implemented as a float with a standard default of 1.5
- IridescenceThicknessRange is correctly implemented as Vector2 with documented defaults [100, 400]
- Both properties are properly validated and cloned
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Verify property types and defaults ast-grep --pattern 'class PBRMaterial { $$$ private _iridescenceRange = new Vector2($_, $_); $$$ shaderData.setFloat(PBRMaterial._iorProp, $_); $$$ }'Length of output: 162
Script:
#!/bin/bash # Search for iridescence and ior related properties with more flexible patterns echo "=== Searching for iridescence thickness range property ===" ast-grep --pattern 'iridescenceThicknessRange' echo -e "\n=== Searching for ior property ===" ast-grep --pattern 'private _ior' # Backup search using ripgrep for more context echo -e "\n=== Backup search with ripgrep ===" rg "iridescenceThicknessRange|_ior" -A 2 -B 2Length of output: 8366
hhhhkrx
added
Rendering
* fix: iridescence bug
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)
What is the current behavior? (You can also link to an open issue here)
What is the new behavior (if this is a feature change)?
Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
Other information:
Summary by CodeRabbit
iridescenceThicknessRangeproperty during duplication.