Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
shaderlab pbr support refraction #2470
shaderlab pbr support refraction #2470
Changes from 1 commit
dd09252
1fc002e
adfdfec
62844aa
ffa2912
1fc63b2
bab9582
174e0e7
47fb197
f9b748c
4ef6387
76b40b1
3abe5c1
b81bbeb
bcc9daf
b9b9558
9d8a37e
84e2f0d
e977cbc
4040c26
420566d
4a3ce3e
6b19600
129ac02
1ff952d
1f011eb
76d9063
d2c26cf
9d9e4ae
02ae05e
a493e26
59e0da3
e062e18
aa434e4
82d9754
4c5eb18
b6c874a
0bf8d73
1f20667
d4b5d11
df27aef
1ba3440
09397f0
e7718de
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Check warning on line 305 in packages/core/src/material/PBRMaterial.ts
Codecov / codecov/patch
packages/core/src/material/PBRMaterial.ts#L304-L305
Check warning on line 316 in packages/core/src/material/PBRMaterial.ts
Codecov / codecov/patch
packages/core/src/material/PBRMaterial.ts#L308-L316
Check warning on line 324 in packages/core/src/material/PBRMaterial.ts
Codecov / codecov/patch
packages/core/src/material/PBRMaterial.ts#L323-L324
Check warning on line 333 in packages/core/src/material/PBRMaterial.ts
Codecov / codecov/patch
packages/core/src/material/PBRMaterial.ts#L327-L333
Check warning on line 341 in packages/core/src/material/PBRMaterial.ts
Codecov / codecov/patch
packages/core/src/material/PBRMaterial.ts#L340-L341
Check warning on line 350 in packages/core/src/material/PBRMaterial.ts
Codecov / codecov/patch
packages/core/src/material/PBRMaterial.ts#L344-L350
Check warning on line 358 in packages/core/src/material/PBRMaterial.ts
Codecov / codecov/patch
packages/core/src/material/PBRMaterial.ts#L357-L358
Check warning on line 365 in packages/core/src/material/PBRMaterial.ts
Codecov / codecov/patch
packages/core/src/material/PBRMaterial.ts#L361-L365
Check warning on line 373 in packages/core/src/material/PBRMaterial.ts
Codecov / codecov/patch
packages/core/src/material/PBRMaterial.ts#L372-L373
Check warning on line 380 in packages/core/src/material/PBRMaterial.ts
Codecov / codecov/patch
packages/core/src/material/PBRMaterial.ts#L376-L380
Check warning on line 388 in packages/core/src/material/PBRMaterial.ts
Codecov / codecov/patch
packages/core/src/material/PBRMaterial.ts#L387-L388
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as above, debounce the macro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cache macro name
Check warning on line 398 in packages/core/src/material/PBRMaterial.ts
Codecov / codecov/patch
packages/core/src/material/PBRMaterial.ts#L391-L398
Check warning on line 406 in packages/core/src/material/PBRMaterial.ts
Codecov / codecov/patch
packages/core/src/material/PBRMaterial.ts#L405-L406
Check warning on line 415 in packages/core/src/material/PBRMaterial.ts
Codecov / codecov/patch
packages/core/src/material/PBRMaterial.ts#L409-L415
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cache absorption state to switch macro
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@todo: do you need
MATERIAL_HAS_ABSORPTION
Check warning on line 454 in packages/core/src/material/PBRMaterial.ts
Codecov / codecov/patch
packages/core/src/material/PBRMaterial.ts#L453-L454
Check warning on line 22 in packages/loader/src/gltf/extensions/KHR_materials_transmission.ts
Codecov / codecov/patch
packages/loader/src/gltf/extensions/KHR_materials_transmission.ts#L11-L22
Check warning on line 33 in packages/loader/src/gltf/extensions/KHR_materials_volume.ts
Codecov / codecov/patch
packages/loader/src/gltf/extensions/KHR_materials_volume.ts#L12-L33
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you can't find a basis for 5 mm, i suggest just keep the two modes, and delete thin mode
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@todo: No need to process if the coord exceeds the screen?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@todo: camera distance
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@todo: diffuse Intensity ?