Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shaderlab pbr support refraction #2470

Merged
merged 44 commits into from
Dec 27, 2024

fix: keep iridescenceRange unified

1fc63b2
Select commit
Loading
Failed to load commit list.
Merged

shaderlab pbr support refraction #2470

fix: keep iridescenceRange unified
1fc63b2
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch failed Dec 20, 2024 in 1s

60.15% of diff hit (target 68.43%)

View this Pull Request on Codecov

60.15% of diff hit (target 68.43%)

Annotations

Check warning on line 316 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L315-L316 

Added lines #L315 - L316 were not covered by tests

Check warning on line 328 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L325-L328 

Added lines #L325 - L328 were not covered by tests

Check warning on line 342 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L341-L342 

Added lines #L341 - L342 were not covered by tests

Check warning on line 348 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L347-L348 

Added lines #L347 - L348 were not covered by tests

Check warning on line 358 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L357-L358 

Added lines #L357 - L358 were not covered by tests

Check warning on line 368 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L361-L368 

Added lines #L361 - L368 were not covered by tests

Check warning on line 376 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L375-L376 

Added lines #L375 - L376 were not covered by tests

Check warning on line 385 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L379-L385 

Added lines #L379 - L385 were not covered by tests

Check warning on line 393 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L392-L393 

Added lines #L392 - L393 were not covered by tests

Check warning on line 400 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L396-L400 

Added lines #L396 - L400 were not covered by tests

Check warning on line 408 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L407-L408 

Added lines #L407 - L408 were not covered by tests

Check warning on line 413 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L411-L413 

Added lines #L411 - L413 were not covered by tests

Check warning on line 421 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L420-L421 

Added lines #L420 - L421 were not covered by tests

Check warning on line 431 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L424-L431 

Added lines #L424 - L431 were not covered by tests

Check warning on line 439 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L438-L439 

Added lines #L438 - L439 were not covered by tests

Check warning on line 448 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L442-L448 

Added lines #L442 - L448 were not covered by tests

Check warning on line 475 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L472-L475 

Added lines #L472 - L475 were not covered by tests

Check warning on line 495 in packages/core/src/material/PBRMaterial.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/core/src/material/PBRMaterial.ts#L494-L495 

Added lines #L494 - L495 were not covered by tests

Check warning on line 22 in packages/loader/src/gltf/extensions/KHR_materials_transmission.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/loader/src/gltf/extensions/KHR_materials_transmission.ts#L11-L22 

Added lines #L11 - L22 were not covered by tests

Check warning on line 33 in packages/loader/src/gltf/extensions/KHR_materials_volume.ts

See this annotation in the file changed.

@codecov codecov / codecov/patch

packages/loader/src/gltf/extensions/KHR_materials_volume.ts#L12-L33 

Added lines #L12 - L33 were not covered by tests
View more details on Codecov