Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ShaderLab variable list declaration & CRLF break & macro #if bug #2465

Merged
merged 26 commits into from
Jan 8, 2025

feat: code opt

434742e
Select commit
Loading
Failed to load commit list.
Merged

Fix ShaderLab variable list declaration & CRLF break & macro #if bug #2465

feat: code opt
434742e
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Jan 8, 2025 in 0s

68.24% (-0.20%) compared to cdb7b57

View this Pull Request on Codecov

68.24% (-0.20%) compared to cdb7b57

Details

Codecov Report

Attention: Patch coverage is 96.38554% with 3 lines in your changes missing coverage. Please review.

Project coverage is 68.24%. Comparing base (cdb7b57) to head (434742e).
Report is 2 commits behind head on dev/1.4.

Files with missing lines Patch % Lines
packages/shader-lab/src/parser/AST.ts 94.11% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           dev/1.4    #2465      +/-   ##
===========================================
- Coverage    68.44%   68.24%   -0.20%     
===========================================
  Files          923      925       +2     
  Lines        95994    96099     +105     
  Branches      8140     8154      +14     
===========================================
- Hits         65702    65583     -119     
- Misses       30038    30260     +222     
- Partials       254      256       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.