Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refact: Optimize Rect _onValueChanged callback. #2407

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

fixup

4cc5b86
Select commit
Loading
Failed to load commit list.
Open

refact: Optimize Rect _onValueChanged callback. #2407

fixup
4cc5b86
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Oct 28, 2024 in 1s

69.20% (-0.28%) compared to e8e8090

View this Pull Request on Codecov

69.20% (-0.28%) compared to e8e8090

Details

Codecov Report

Attention: Patch coverage is 46.15385% with 7 lines in your changes missing coverage. Please review.

Project coverage is 69.20%. Comparing base (e8e8090) to head (4cc5b86).

Files with missing lines Patch % Lines
packages/math/src/Rect.ts 46.15% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2407      +/-   ##
==========================================
- Coverage   69.48%   69.20%   -0.28%     
==========================================
  Files         522      522              
  Lines       27356    27362       +6     
  Branches     4096     4092       -4     
==========================================
- Hits        19009    18937      -72     
- Misses       6847     6936      +89     
+ Partials     1500     1489      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.