Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lightmap in pbr workflow #1939

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

zhuxudong
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature, Enhance

What is the current behavior? (You can also link to an open issue here)

use BakePBRMaterial in @galacean/runtime-toolkit

What is the new behavior (if this is a feature change)?

add property 'lightmap'、dirLightmaplightmapTilingOffset in PBRBaseMaterial

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

No.

Other information:

  • must have uv1 channel, just RENDERER_HAS_UV1
  • must use RGBM format and 5.0 scale factor from editor

@zhuxudong zhuxudong added Rendering Rendering related functions scene labels Jan 3, 2024
@zhuxudong zhuxudong added this to the 1.2 milestone Jan 3, 2024
@zhuxudong zhuxudong requested a review from GuoLei1990 January 3, 2024 07:37
@zhuxudong zhuxudong self-assigned this Jan 3, 2024
@GuoLei1990 GuoLei1990 changed the base branch from dev/1.2 to main March 11, 2024 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Rendering Rendering related functions scene
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

1 participant