-
-
Notifications
You must be signed in to change notification settings - Fork 309
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add uniform decorator for improving custom material code #1713
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## dev/1.1 #1713 +/- ##
===========================================
+ Coverage 61.37% 61.97% +0.59%
===========================================
Files 410 432 +22
Lines 21834 22447 +613
Branches 3140 3190 +50
===========================================
+ Hits 13401 13911 +510
- Misses 7244 7315 +71
- Partials 1189 1221 +32
☔ View full report in Codecov by Sentry. |
With uniform decorator, it will be easier for create uniform property in material class.
Features:
1. support define glsl variable name
2. support macro
3. support keeping reference