Skip to content

Fix Default Timeout Value as per Docs #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

AltafShk
Copy link

@AltafShk AltafShk commented Aug 5, 2022

The documentation says that the default gracefulShutdownTimeout is 5000ms but actually it is 1000ms. Changed the config to have 5000ms, the value specified in the docs.

@GuillaumeCisco
Copy link

Actually, there is a retry set to 10 in the code.
so with 10 retries and 1000ms by default, the maximum for waiting is 10sec.
Why don't we get back to only 1 retry?
Where did you find 5s from the doc?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants