Remove weird, unused, breaking behavior #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was an if statement in the parseData function (in the npm module, it is in modules/parse.fn.js) which would return the full Array returned by rgx.exec(data), instead of the String indicating the match itself. The if statement did not seem to be actually used anywhere; it only broke things (for example, inline parsing in inline Array selectors; for example, {"myInfo":["a @ href || [a-z]+"]} would cause an error because parseData (in this case, which had multiple set to true) returned an Array, not a String). This removes that if statement.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was an if statement in the
parseDatafunction (in the npm module, it is inmodules/parse.fn.js) which would return the fullArrayreturned byrgx.exec(data), instead of theStringindicating the match itself.The if statement did not seem to be actually used anywhere; it only broke things (for example, inline parsing in inline Array selectors; for example, scraping with the following frame
would cause an error because parseData (in this case, which had multiple set to true) returned an Array, not a String). This PR removes that if statement.