Fix interferometer mappings, b_field_tor_calc and pyuda imports#394
Open
AreWeDreaming wants to merge 7 commits intomasterfrom
Open
Fix interferometer mappings, b_field_tor_calc and pyuda imports#394AreWeDreaming wants to merge 7 commits intomasterfrom
AreWeDreaming wants to merge 7 commits intomasterfrom
Conversation
Collaborator
|
The changes look good to me. Although I don't see any |
Collaborator
Author
|
Yeah that was fixed when we merged #391 |
torrinba
approved these changes
Feb 20, 2026
Collaborator
torrinba
left a comment
torrinba
left a comment
There was a problem hiding this comment.
I'm still in favor of renaming this PR for better traceability, but these fixes look good to me and should be merged without delay
AreWeDreaming
changed the title
AreWeDreaming
changed the title
Collaborator
|
@jmcclena can you test that this still works for MAST-U with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes introduced when working on interferometry and ece