Improve UI of New Extension page #13
Conversation
|
I really appreciate your project. Its really helpful, i wanna be one of its maintainers if that is okay |
|
Thank you for your PR @sickboydroid. I'm glad to see your interest in the project, and I am super grateful for your contributions! Unfortunately, I'm falling horridly behind on work so I will take some time to review your PR. I'm really sorry about the delay. I will get to this ASAP. |
|
Yeah sure, btw I ran the extension to make sure everything was fine and it was working good. |
|
Hey! I know you are busy but can you review my pull request and merge. I want to use this new design. And I also wanna contribute further if you merge this one Thanks |
|
Truly sorry for the delay @sickboydroid! I'll review it by the end of this weekend. Thank you for pinging me. |
| <p class="title">Create New Chrome Extension</p> | ||
| </div> | ||
| <div class="project-form"> | ||
| <div class="inputs"> |
There was a problem hiding this comment.
Can we keep the indentation to 4 spaces please?
There was a problem hiding this comment.
sure, I guess it was my editors default setting and i didn't pay much attention to it
| if (res.status === "GIVE") { | ||
| document.getElementById("location_label").innerHTML = res.message.path; | ||
| } else if (res.status === "ERR") { | ||
| document.querySelector(".loading").style.display = "none"; |
There was a problem hiding this comment.
Is there a specific reason for using querySelector over getElementById here?
| @@ -1,20 +1,216 @@ | |||
| img { | |||
| margin-top: 1%; | |||
| :root { | |||
There was a problem hiding this comment.
Thank you for all these styling changes
| ellipsisDotCount++; | ||
| } | ||
| }, 500); |
|
Thank you so much for your work @sickboydroid. Please email me at [email protected] if you want to discuss becoming a maintainer for this project. |
|
Check your mail box |
I have improved the "New Chrome Extension" heavily. Please build and run the extension at least once to see if everything is working fine. If not, let me know