Remove warnings #190
Open
Remove warnings #190
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warnings fixed (MSVC warning codes under /W4): core/format.inl(378,21): warning C4244: 'initializing': conversion from 'const glm::uint32' to 'glm::uint16', possible loss of data core\storage_linear.inl(110,103): warning C4458: declaration of 'Extent' hides class member core\storage_linear.inl(116,103): warning C4458: declaration of 'Extent' hides class member core\storage_linear.inl(122,103): warning C4458: declaration of 'Extent' hides class member core\storage_linear.inl(132,22): warning C4458: declaration of 'BlockCount' hides class member core/image.inl(216,98): warning C4458: declaration of 'BaseLevel' hides class member gl.hpp(361,28): warning C4458: declaration of 'Profile' hides class member core/gl.inl(330,39): warning C4458: declaration of 'FormatDesc' hides class member core/gl.inl(357,61): warning C4458: declaration of 'FormatDesc' hides class member core/load_ktx.inl(53,58): warning C4100: 'Size': unreferenced formal parameter core/save_dds.inl(105,61): warning C5054: operator '|': deprecated between enumerations of different types Additionally fixed unused argument warnings when GLI_ASSERT is disabled.
|
This pull request makes some of the same changes as #175, but uses Additionaly removes unused variable warnings in release build, what was done before in #185, but that pull request was closed without merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings fixed (MSVC warning codes under /W4):
core/format.inl(378,21): warning C4244: 'initializing': conversion from 'const glm::uint32' to 'glm::uint16', possible loss of data
core\storage_linear.inl(110,103): warning C4458: declaration of 'Extent' hides class member
core\storage_linear.inl(116,103): warning C4458: declaration of 'Extent' hides class member
core\storage_linear.inl(122,103): warning C4458: declaration of 'Extent' hides class member
core\storage_linear.inl(132,22): warning C4458: declaration of 'BlockCount' hides class member
core/image.inl(216,98): warning C4458: declaration of 'BaseLevel' hides class member
gl.hpp(361,28): warning C4458: declaration of 'Profile' hides class member
core/gl.inl(330,39): warning C4458: declaration of 'FormatDesc' hides class member
core/gl.inl(357,61): warning C4458: declaration of 'FormatDesc' hides class member
core/load_ktx.inl(53,58): warning C4100: 'Size': unreferenced formal parameter
core/save_dds.inl(105,61): warning C5054: operator '|': deprecated between enumerations of different types
Additionally fixed unused argument warnings when GLI_ASSERT is disabled (to do this added GLI_UNUSED macro).