Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't redefine preprocessor symbols #189

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

seanharmer
Copy link

When using gli in a project that also uses glm and adds
preprocessor definitions on the command line, gli triggers
compiler warnings such as:

gli/./core/levels.inl:2: warning: "GLM_ENABLE_EXPERIMENTAL" redefined

This commit fixes this by only defining the preprocessor symbols
if they are not already present. This helps maintain warning-free
downstream code.

When using gli in a project that also uses glm and adds
preprocessor definitions on the command line, gli triggers
compiler warnings such as:

gli/./core/levels.inl:2: warning: "GLM_ENABLE_EXPERIMENTAL" redefined

This commit fixes this by only defining the preprocessor symbols
if they are not already present. This helps maintain warning-free
downstream code.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant