Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lookup go.mod in current or parent directories #48

Merged
merged 4 commits into from
Mar 3, 2025

Conversation

sdassow
Copy link
Contributor

@sdassow sdassow commented Feb 12, 2025

Fix for #46

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
…n the same directory
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a good change, but can you add a test?
Are you sure that the same "/" is the root directory on all platforms (Windows, looking at you)...

@sdassow
Copy link
Contributor Author

sdassow commented Mar 2, 2025

Seems like a good change, but can you add a test?

Done.

Are you sure that the same "/" is the root directory on all platforms (Windows, looking at you)...

No. Thanks for pointing this out, changed the logic to avoid this entirely, and the new tests appear to be happy on windows.

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change thanks

@sdassow sdassow merged commit 876e366 into fyne-io:main Mar 3, 2025
7 checks passed
@sdassow sdassow deleted the feature/env-lookup-go-mod branch March 3, 2025 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants