Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'verbose' option to package command #42

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sdassow
Copy link
Contributor

@sdassow sdassow commented Feb 10, 2025

This is picking up from fyne-io/fyne#3352 to fix fyne-io/fyne#3069.

It passes the verbose value to the mobile build, and shows xcrun command invocations when enabled.

Leaves other flags as they are.

… show xcrun command invocations when enabled
@andydotxyz
Copy link
Member

andydotxyz commented Feb 12, 2025

I think this really brings the conversation over from the last issue as to what is the difference between verbose and debug?

I am trying to read up on what other places do and it seems (at a glance?) that verbose is about command output and debug is about replicating steps used to create that result (i.e. command logging).

See how the mobile package uses buildV to set the stdout and stderr to pass through, but does not (at least in iOS) pass the commands used to the output. It's buildX that is used to print things like the mkdir etc.

@sdassow
Copy link
Contributor Author

sdassow commented Feb 12, 2025

I think this really brings the conversation over from the last issue as to what is the difference between verbose and debug?

I am trying to read up on what other places do and it seems (at a glance?) that verbose is about command output and debug is about replicating steps used to create that result (i.e. command logging).

From other tools I'm used to verbose showing commands etc, and passwords and stuff only with debug enabled. Some tools use multiple verbose flags for that, indicating that we're talking about log levels I think.

See how the mobile package uses buildV to set the stdout and stderr to pass through, but does not (at least in iOS) pass the commands used to the output. It's buildX that is used to print things like the mkdir etc.

Oh, if the wires are crossed like this (different flags for different tools), then I missed it and wasn't clear to me from the original PR discussion.

@andydotxyz
Copy link
Member

I don't have the answers but did want to highlight the potential confusion here. What should verbose be outputting and what should it not - and is the other stuff outputted by a debug flag...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add debug option and verbose output for all commands executed by fyne while building a release
2 participants