Add an option to serve in release mode #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gives a bit more performance and is useful for developers if they have any code using the build mode lookups that we have.
|
I'm not sure what "serve -release" does... won't this imply that the fyne tool is a production runner for web Fyne apps? |
|
Would "-no-debug" be better? |
|
Given that debug is off by default and we have a --debug option I'd have thought changing it so debug was only attached when debug mode is on would be the logical approach. |
|
Hmm, yeah. Good point. The problem I'm trying to solve is that I want the improved performance from building in release mode without webgl_debug.js. Note sure what the best option is? |
Remove the debug file unless --debug flag is set? |
|
Sounds good. That can also enable the visual debug mode. |
|
I have changed the implementation now. Should be good to go :) |
andydotxyz
approved these changes
Feb 26, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gives a bit more performance (related to if we have webgl debug on or not) and is generally useful for developers if they have any code using the build mode lookups that we have.