Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement new Style() method of TermGridStyle interface #85

Merged
merged 4 commits into from
Jun 18, 2024

Conversation

mgazza
Copy link
Contributor

@mgazza mgazza commented Jun 12, 2024

required as per fyne-io/fyne#4244

@andydotxyz
Copy link
Member

Looks good, but should include the go.mod update for the Fyne version that added this support I think

@mgazza
Copy link
Contributor Author

mgazza commented Jun 17, 2024

Yep, I'll update this now its been merged

@andydotxyz
Copy link
Member

Apologies for the failure - somehow a previous PR triggered a break that was not caught. I pushed a fix, so merging in latest develop should fix it.

@mgazza
Copy link
Contributor Author

mgazza commented Jun 17, 2024

no worries, rebased

@andydotxyz
Copy link
Member

Oh my mistake - it was not a rebase that it needed, it was an update of the fyne dep in go.mod - I forgot which repository we are in sorry.

Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for this :)

@andydotxyz andydotxyz merged commit 9d4252f into fyne-io:master Jun 18, 2024
5 checks passed
@mgazza mgazza deleted the implement-textgridstyle branch June 18, 2024 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants