Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always copy selected text #100

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Always copy selected text #100

wants to merge 1 commit into from

Conversation

mgazza
Copy link
Contributor

@mgazza mgazza commented Dec 23, 2024

Always copy the selected text on the selection end

@mgazza
Always copy selected text
897826d 
Always copy selected text on selection end
andydotxyz
andydotxyz reviewed Dec 23, 2024
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure? I'm not aware of any other widgets or terminals that (across platforms) automatically copy anything that is selected...

@mgazza
Copy link
Contributor Author

mgazza commented Dec 23, 2024

Yeah this is exactly what Iterm does

@andydotxyz
Copy link
Member

Fair enough, I guess there are enough terminal apps that some may do this. But the majority don't.
With this code change your forcing this behaviour on all terminal apps.
It is possible, and would it not be better, to elect to have this behaviour in your app instead of all (just extend Terminal and override the DragEnd method?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgazza @andydotxyz