Modernise in preparation for v0.1.0 release #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a go.mod file with the module statement to avoid accidental uses of non-canonical module paths. Other statements will be added later.
This allows using Metal API via goxjs/glfw.
Use the browser's focus and blur events to implement the focus callback, which is informed when the browser window is in focus (active window) or not. Depending on whether or not we want to consider multiple tabs as "all focused" or if each is focused individually, we may need to change the listener to attach to the document instead of the window. The browser functionality related to that has not been explored. Fixes goxjs#12. GitHub-Pull-Request: goxjs#14
Implement the close callback via the browser's beforeunload event, which is fired just prior to the page being unloaded. It might be worth documenting there are some limitations on what the callback handler can do with the DOM depending on the browser. In some, opening a dialog is not allowed (to prevent annoying pop-ups). GitHub-Pull-Request: goxjs#15
3 tasks
andydotxyz
approved these changes
Feb 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates workflows, adds in a few useful changes from upstream to call more of the internal glfw callbacks and updates some deps.