Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add new canvas.RecolorSVG API #5345

Merged
merged 9 commits into from
Jan 5, 2025
Merged

Add new canvas.RecolorSVG API #5345

merged 9 commits into from
Jan 5, 2025
+51 −17

Conversation

dweymouth
Copy link
Contributor

Description:

Fixes #4815

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

Where applicable:

  • Public APIs match existing style and have Since: line.

Jacalz
Jacalz requested changes Dec 29, 2024
View reviewed changes
internal/svg/svg.go Outdated Show resolved Hide resolved
@dweymouth dweymouth changed the title Add new canvas.ColorizeSVG API Add new canvas.RecolorSVG API Dec 29, 2024
@dweymouth
Copy link
Contributor Author

CI Failures appear to be unrelated flakiness

andydotxyz
andydotxyz requested changes Jan 1, 2025
View reviewed changes
canvas/canvas.go Outdated Show resolved Hide resolved
Jacalz
Jacalz previously requested changes Jan 2, 2025
View reviewed changes
internal/svg/svg.go Outdated Show resolved Hide resolved
andydotxyz
andydotxyz approved these changes Jan 3, 2025
View reviewed changes
Copy link
Member

@andydotxyz andydotxyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks like a great new helper

@dweymouth dweymouth requested a review from Jacalz January 3, 2025 22:13
@dweymouth dweymouth dismissed Jacalz’s stale review January 5, 2025 15:16

Requested changed made

@dweymouth dweymouth merged commit bd7d51f into fyne-io:develop Jan 5, 2025
12 checks passed
@dweymouth dweymouth deleted the colorize-svg branch January 5, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andydotxyz andydotxyz andydotxyz approved these changes

@Jacalz Jacalz Awaiting requested review from Jacalz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dweymouth @andydotxyz @Jacalz