Skip to content

Commit

Permalink
Merge pull request #246 from fyne-io/build-4-darwin-from-linux-windows
Browse files Browse the repository at this point in the history
Ldflags where only needed with older version of zig which we have updated since then.
  • Loading branch information
andydotxyz authored May 29, 2024
2 parents a730062 + 70b1bf8 commit a4d0a47
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions internal/command/darwin.go
Original file line number Diff line number Diff line change
Expand Up @@ -187,8 +187,6 @@ func (cmd *darwin) setupContainerImages(flags *darwinFlags, args []string) error
return fmt.Errorf("could not make command context for %s OS: %s", darwinOS, err)
}

flags.Ldflags += " -s -w"

ctx, err := makeDefaultContext(flags.CommonFlags, args)
if err != nil {
return err
Expand All @@ -200,7 +198,7 @@ func (cmd *darwin) setupContainerImages(flags *darwinFlags, args []string) error

ctx.Category = flags.Category

// Following settings are needed to cross compile with zig 0.9.1
// Following settings are needed to cross compile with zig
ctx.BuildMode = "pie"

cmd.defaultContext = ctx
Expand Down

0 comments on commit a4d0a47

Please sign in to comment.