Added Example Code to "datalistener.md" #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While I do not know your conventions in this context, I would be happy to get feedback to improve this contribution.
removed accidenttally added call to ViewModel.Start() in DataListener()
andydotxyz
requested changes
Oct 24, 2024
inlined and simplified ViewModel - renamed isStarted to isRunning to indicate that it is not reflecting the state of the StartButton, but the other way round - removed testing-code - externalized the handleTap-func for the demo's main purpose it could actually be empty, without it feels incomplete, with it the scope is extended - I am unsure.
andydotxyz
requested changes
Oct 28, 2024
removed empty lines - I personally prefer at least the opening empty line, to make the function's signature stand out. - the closing one, I missed - the import "testing", was a copy-paste leftover In addition I renamed the function, to better describe its intent. Thanks for your feedback
andydotxyz
requested changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While I do not know your conventions in this context, I would be happy to get feedback to improve this contribution.