Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update extending-widgets.md #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

pierrec
Copy link

@pierrec pierrec commented Sep 9, 2024

Fix interfaces used for double tap.

Fix interfaces used for double tap.
@andydotxyz
Copy link
Member

Why are you replacing secondary tapped with double tapped? Its not the same thing and the latter is not even recommended…

@pierrec
Copy link
Author

pierrec commented Sep 9, 2024

Hmm... A few things that prompted me with this PR with the current documentation:

  • as per the wording, it looks like the Tappable interface requires 2 methods, which is not the case
    The interface required has two functions, Tapped(*PointEvent) and TappedSecondary(*PointEvent)
  • I could not find the TappedSecondary interface but found DoubleTappable, I therefore thought this was a missed update in the doc! Clearly wrong.

Maybe the doc should also clarify why DoubleTappable is not recommended? I am actually trying to use it.

@andydotxyz
Copy link
Member

TappedSecondary used to be in Tappable but we moved it out to a newer SecondaryTappable interface.

In general double tapping is for pro-users so we don't recommend it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants