-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Wayland deps to install commands #14
base: main
Are you sure you want to change the base?
Conversation
Ticking for Debian :) |
Just an FYI - in Debian at least this will only work if Gnome dev (gnome-software-plugin-deb) is already installed. In fact this new decoration requirement makes Fyne dependant upon GTK which I did not fully realise until now. I don't think it should be listed as a mandatory requirement, but if it isn't then will people using the apps get no borders? |
Fedora has been tested. Others have not.
Solus works fine. Gave up Void because their installed is crap. |
Is it really dependent on GTK? As far as I can tell from libdecor, it is only linking to cairo but not GTK itself. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we agreed on the call that the decor dependency should not be included, though the others may still be needed.
Wayland builds on OpenSUSE are currently broken, see go-gl/glfw#402. Should hopefully be a relatively simple fix to add the include path. |
I believe this is ready. All the big linux distros have been tested and a bug about openSUSE has been filed but that should be a simple fix hopefully (all required packages are installed now none the less). The obscure ones have more of a manual gui setup and are a lot harder for me to test but the packages that we now install do exist (checked in the corresponding package repos for naming and so on). |
This reverts commit d76b761. Wayland builds already work in CI without installing these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Added some thoughts about the wayland libdecor.
* `sudo apt-get install golang gcc libegl1-mesa-dev xorg-dev` | ||
* `sudo apt-get install golang gcc libegl1-mesa-dev xorg-dev libxkbcommon-dev` | ||
|
||
**NOTE:** Some Wayland compositors (Gnome's compositor Mutter etc.) do not support server side decorations resulting in Fyne applications showing up without window borders. Installing `libdecor` should solve these issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Raspberry Pi now uses Wayfire which seems to support server side rendering. So this should not be needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes but you can also install something like Ubuntu 24.04 om Raspberry Pi and that ides Gnome. Maybe the RPi tab (which just checks arm64 right?) needs to be updated with more distribution options?
`nix-shell -p libGL pkg-config xorg.libX11.dev xorg.libXcursor xorg.libXi xorg.libXinerama xorg.libXrandr xorg.libXxf86vm` | ||
`nix-shell -p libGL pkg-config xorg.libX11.dev xorg.libXcursor xorg.libXi xorg.libXinerama xorg.libXrandr xorg.libXxf86vm libxkbcommon wayland` | ||
|
||
**NOTE:** Some Wayland compositors (Gnome's compositor Mutter etc.) do not support server side decorations resulting in Fyne applications showing up without window borders. Installing `libdecor` should solve these issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a runtime and not a compile-time issue so I'm not sure it belongs here. Or maybe it does but should also appear in the troubleshooting page?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From what I can tell, it is a bit of both. You can install it either at compile time or runtime. I have a vague recollection that I got better borders with -devel
packages than just using it at runtime but I'll check. Adding it to troubleshooting is a good idea but I think it is worth having here as well.
Description
Builds on #13. The idea here is to add Wayland deps everywhere so people more easily can use that support.
Distributions to be tested:
How to test:
Build a Fyne application with
-tags wayland
.