Implemented image caching solution (closes #14) #19
Conversation
| * @private | ||
| */ | ||
| reloadData() { | ||
| this.emptyImageCache(); |
There was a problem hiding this comment.
Need a test for this
There was a problem hiding this comment.
might be worth it to file follow up to add a formal way to "append" content (ie. new content bellow but the content that was there didn't move). We'll be able to do a bunch of optimizations, including not throwing away the image cache.
There was a problem hiding this comment.
That's a really good idea! Filed issue #20
|
I nitpick because I care, but this is a really nice PR! Great job! |
wilsonpage
force-pushed
the
14-image-caching
branch
from
fa04501 to
cd67b68
Compare
|
@etiennesegonzac ready for final review. I added a feature to limit the imageCache by length as well as bytes. This is to prevent us storing too many strings when Blobs are not used. So by default we store up to |
| * half of the cached images not currently | ||
| * in use, then we checkImageCacheLimit() | ||
| * once more. | ||
| * |
There was a problem hiding this comment.
I like the approach!
|
Apart from that we're good to go! |
wilsonpage
force-pushed
the
14-image-caching
branch
from
cd67b68 to
b34941c
Compare
|
@etiennesegonzac fixed and added test to prove. |
wilsonpage
force-pushed
the
14-image-caching
branch
from
b34941c to
f76a317
Compare
Implemented image caching solution (closes #14)
No description provided.