Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wordpress-fargate: update modules and providers #30

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jre21
Copy link

@jre21 jre21 commented Jun 1, 2021

This pull request is one of several changes I made in the course of adapting the wordpress-fargate recipe to my own use. I decided to break up the changes by topic area to make reviewing them more manageable. This PR is the first of four.

This change is mostly housekeeping. I've updated the terraform providers and modules to ensure that we use their latest major releases. The module updates required some minor code changes, and I've set the minimum version for the aws provider to 3.38.0 in order to take advantage of the newly-introduced default_tags feature, which defines a default set of tags for all AWS resources in one shot, rather than having to apply them to each resource individually.

@jre21
Copy link
Author

jre21 commented Jun 5, 2021

@sunilkumarmohanty When you get a chance, could you please take a look at this PR as well as #31, #32, and #33?

peterkc added a commit to peterkc-devops/terraform-examples that referenced this pull request Jul 25, 2021
commit fbd1fef
Author: Jacob Emmert-Aronson <[email protected]>
Date:   Mon May 31 17:27:14 2021 -0700

    Use the AWS provider's new default_tags argument

commit 821d30c
Author: Jacob Emmert-Aronson <[email protected]>
Date:   Mon May 31 15:58:21 2021 -0700

    Update dependent modules to latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant