Update sendExtrinsic.ts... #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `InBlock` as an acceptable state, to resolve the promise as quickly as possible, in case waiting for `Finalized` state taking too long.
rupolygon
reviewed
Mar 14, 2024
Comment on lines
+48
to
+50
| const blockHash: status.isFinalized | ||
| ? status.asFinalized.toString() | ||
| : status.asInBlock.toString(), |
There was a problem hiding this comment.
I think something is missing here, instead of using : use =
Suggested change
| const blockHash: status.isFinalized | |
| ? status.asFinalized.toString() | |
| : status.asInBlock.toString(), | |
| const blockHash = status.isFinalized | |
| ? status.asFinalized.toString() | |
| : status.asInBlock.toString(), |
rupolygon
reviewed
Mar 14, 2024
rupolygon
left a comment
rupolygon
left a comment
There was a problem hiding this comment.
Something is missing here, instead of using : use =
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
InBlockas an acceptable state, to resolve the promise as quickly as possible, in case waiting forFinalizedstate taking too long.Checklist