Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

English support for the demo by wasm #24

Merged
merged 3 commits into from
Oct 25, 2023
Merged

English support for the demo by wasm #24

merged 3 commits into from
Oct 25, 2023

Conversation

ppputtyo
Copy link
Contributor

@ppputtyo ppputtyo commented Oct 21, 2023 •
edited
Loading

wasm版デモの英語版に対応しました

  • 既存のwasm/index.html(日本語で記述)をwasm/ja.htmlに変更
  • 英語版のwasm/index.htmlを新たに作成

Close #23
Close #26

@ppputtyo ppputtyo requested a review from tanzaku October 21, 2023 02:45
tanzaku
tanzaku reviewed Oct 23, 2023
View reviewed changes
wasm/index.html Outdated Show resolved Hide resolved
@ppputtyo
Copy link
Contributor Author

@tanzaku

英語版の方で予約語とテーブル・カラム名のtooltipが表示されなくなっていた問題を修正しました。また、JOINの例も修正を行いました。

追加で以下の修正も行いました。

  • tooltipsが本文と被っていたので位置を少し右に移動
  • tooltipsにおけるupper, lower, perserveの順番がドロップダウンメニューと違っていたので修正

@tanzaku
Copy link
Collaborator

tanzaku commented Oct 25, 2023

ご対応ありがとうございます！
LGTM

@tanzaku tanzaku merged commit 857b29d into main Oct 25, 2023
@tanzaku tanzaku deleted the dev_kawabuchi_english_support_for_demo branch October 25, 2023 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tanzaku tanzaku tanzaku left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect example for join option English support for the demo by wasm
2 participants
@ppputtyo @tanzaku