Merge rust-embedded#73

73: Use File.read_exact instead of File.read r=eldruin a=jath03 As the documentation says, `I2CDevice.read` is supposed to "fill the provided slice", which `File.read` on it's own doesn't do. Using `File.read_exact` instead will accomplish the intended behavior. https://doc.rust-lang.org/std/fs/struct.File.html#method.read_exact-1 Co-authored-by: Jack <[email protected]>
fusion-engineering-forks · Jun 7, 2022 · efb1090 · efb1090
2 parents 385ea5d + f6858e4
commit efb1090
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -9,6 +9,7 @@ Versioning](https://semver.org/spec/v2.0.0.html).
 ## [Unreleased]
 
 - Updated nix to version `0.24`; only use the `ioctl` feature.
+- Use `File.read_exact` instead of `File.read` in `LinuxI2CDevice.read` so that the buffer is filled.
 
 ## [v0.5.1] - 2021-11-22
 

diff --git a/src/linux.rs b/src/linux.rs
@@ -175,7 +175,7 @@ impl I2CDevice for LinuxI2CDevice {
 
     /// Read data from the device to fill the provided slice
     fn read(&mut self, data: &mut [u8]) -> Result<(), LinuxI2CError> {
-        self.devfile.read(data).map_err(From::from).map(drop)
+        self.devfile.read_exact(data).map_err(From::from).map(drop)
     }
 
     /// Write the provided buffer to the device