Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of theme structure #1

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Initial implementation of theme structure #1

wants to merge 1 commit into from

Conversation

eluciano11
Copy link
Contributor

No description provided.

Jpadilla1
Jpadilla1 requested changes Apr 22, 2019
View reviewed changes
theme/typography.ts Outdated Show resolved Hide resolved
theme/colors.ts Outdated Show resolved Hide resolved
theme/typography.ts Outdated Show resolved Hide resolved
theme/typography.ts Outdated Show resolved Hide resolved
theme/units.ts Outdated Show resolved Hide resolved
@Jpadilla1
Copy link
Collaborator

After my initial review, I was thinking more about the goals we want to achieve with this UIKit and I believe it's beneficial to understand what we are building and the benefits we are giving to end user.

In no particular order, these are some things I think we should consider as goals:

  • Provide a set of configurable styles without having knowledge of the underlying code rendering the UI component to the screen
  • Allow dynamic styles by providing support for themes
  • Provide generated documentation and playground for end users to interact with components before using them
  • Accessible out of the box

@Jpadilla1
Copy link
Collaborator

Provide a set of configurable styles without having knowledge of the underlying code rendering the UI component to the screen

Building this lib from scratch to me sounds like we don't have a solution that meets our needs which might not be true. I was looking at https://github.com/styled-system/styled-system the other day and looks like it fits our needs.

@eluciano11
Copy link
Contributor Author

eluciano11 commented Apr 22, 2019 •
edited
Loading

@jpadilla yeah, I agree. styled-system is probably a good idea. I can adjust a couple of things so we can comply with their specs.

@eluciano11
Copy link
Contributor Author

@Jpadilla1 come to think of it, I think we should use Rebass as the base for the components. It already has a couple of components, the library is unopinionated and it's built on top of styled-system.

https://rebassjs.org/

@eluciano11
Copy link
Contributor Author

@jpadilla sorry for mentioning you earlier hehe.

@Jpadilla1
Copy link
Collaborator

I'm down for rebass and LOL

@eluciano11
Adds initial work on theme structure.
7cf6a59 
Adds initial work theme colors, spacing, radius and typography.

Adds typography sizes

WIP - Feedback

Adds rebass

Adds initial theme changes

Adds theme provider to stories

Moves stories to ts

Adds button variants and placeholder colors

Visualizes palette

Adds font weights, space, radius and buttons

Cleans up variants file

Updates palette display

Moves theme to root

Cleans up some type definitions
@eluciano11 eluciano11 marked this pull request as ready for review April 27, 2019 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froi froi froi left review comments

@Jpadilla1 Jpadilla1 Jpadilla1 approved these changes

Assignees

@Jpadilla1 Jpadilla1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eluciano11 @Jpadilla1 @froi