docs(#7402): document silent-fallback error swallowing - #7404
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add a subsection under Error handling and naming conventions in docs/contributing/go-code.md for the classify-before-fallback anti-pattern. Fallback-on-error paths must distinguish the expected trigger from unexpected or transient failures and log or surface the unexpected case, matching forge.IsTransient usage in the GitLab MR inline-comment helpers from PR #7342. Reviewers should flag unclassified degraded fallbacks as medium severity, same bar as the Timeout()/DeadlineExceeded pitfall. Closes #7402
|
🤖 Review · Commit: |
|
🤖 Finished Review · ✅ Success · Started 2:10 PM UTC · Completed 2:27 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $2.28 |
Site previewPreview: https://449a7046-site.fullsend-ai.workers.dev Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Risk Assessment: moderate (2/5) DetailsDocs-only, single-file, bot-authored PR closely matching a freshly-filed low-priority issue with no risk labels (Tier1/Tier3 average 1.0), but the target file has volatile git history (high 30-day churn, broad author contention) pulling the 30%-weighted Tier2 average to 3.0; weighted composite rounds to a moderate score of 2. |
|
Looks good to me |
![fullsend-ai-review[bot]](https://avatars.githubusercontent.com/in/3478501?s=60&v=4){kind=small}
fullsend-ai-review
Bot
added
the
ready-for-merge
Summary
Document the silent-fallback error-swallowing anti-pattern in
docs/contributing/go-code.mdso new fallback-on-error paths classify unexpected failures instead of treating every error as a successful downgrade.Related Issue
#7402 (filed from the extra review/fix cycle on PR #7342).
Changes
Timeout() bool/context.DeadlineExceededentry.forge.IsTransientas the canonical classifier, and the GitLabpostInlineComments/postDiffDiscussion/getMergeRequestDiffRefsworked example from PR feat(#7328): post GitLab review findings as inline discussions #7342.Testing
lychee --offline --include-fragmentson the edited file: 0 errors../hack/lint-docs-linkspassed.Checklist
!for breaking changes)Closes #7402
Post-script verification
agent/7402-silent-fallback-error-docs)7e429a12e61a9f7b25b6f29b03094998328cddad..HEAD)