Locale Switcher #75
Locale Switcher #75
Conversation
Deploying ui with
|
| Latest commit: |
9592310
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://cdc66043.ui-eey.pages.dev |
| Branch Preview URL: | https://0-5-localeswitcher.ui-eey.pages.dev |
| @@ -0,0 +1,27 @@ | |||
| --- | |||
| import Select from 'fulldev-ui/components/Select.astro' | |||
There was a problem hiding this comment.
destructure the props needed, and also a restprops
| Astro.props.locales && ( | ||
| <Select | ||
| name="locale-switcher" | ||
| options={Astro.props.locales} |
There was a problem hiding this comment.
use the destructured props and also pass the restprops
| @@ -0,0 +1,27 @@ | |||
| --- | |||
| import Select from 'fulldev-ui/components/Select.astro' | |||
There was a problem hiding this comment.
Add a type, you can use a modified version of ComponentProps You should omit values not needed, and add values that are unique for the LocaleSelect
| const target = event.target | ||
| const selectedLocale = target.value | ||
| const currentUrl = new URL(window.location.href) | ||
| currentUrl.pathname = '/' + selectedLocale + currentUrl.pathname |
There was a problem hiding this comment.
Make this a template string instead, like /${selectedLocale}....etc
| const target = event.target | ||
| const selectedLocale = target.value | ||
| const currentUrl = new URL(window.location.href) | ||
| currentUrl.pathname = '/' + selectedLocale + currentUrl.pathname |
There was a problem hiding this comment.
make this a new const instead
| @@ -0,0 +1,18 @@ | |||
| --- | |||
There was a problem hiding this comment.
Make it a habit to turn PascalCase in component names to kebab-case in md/mdx etc
So locale-select.mdx
| import LocaleSelect from 'fulldev-ui/components/LocaleSelect.astro' | ||
| --- | ||
|
|
||
| <LocaleSelect /> |
There was a problem hiding this comment.
I think this will be invisible because there are no locales passes as props, right?
No description provided.