Addition: Toggle component #45
Conversation
✅ Deploy Preview for fulldev-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
| {radius} | ||
| {...rest} | ||
| > | ||
| <label class="toggle-element"> |
There was a problem hiding this comment.
You have the Root and in that directly a label child. You do not need both, you can combine them into one.
set as="label" on Root and remove it from the props.
There was a problem hiding this comment.
Now I'm thinking about it, maybe you can even use the component, so you have the right styles right away. Set a as="label" on that.
| type="checkbox" | ||
| class="checkbox" | ||
| /> | ||
| <div class="toggle-content"> |
There was a problem hiding this comment.
I don't think you need this div either, you can achieve the same result without it
| {...rest} | ||
| > | ||
| <label class="toggle-element"> | ||
| <input |
There was a problem hiding this comment.
This input does not need a checkbox class. You use nested styles, so you can just use input instead of .checkbox. Reason being is that the .checkbox class can conflict with the checkbox component
| import Toggle from 'fulldev-ui/components/Toggle.astro' | ||
| --- | ||
|
|
||
| <Toggle set:html="A" toggled={true} /> |
There was a problem hiding this comment.
You can use html instead of set:html
| } | ||
|
|
||
| .checkbox:hover:not(:checked) ~ .toggle-content .icon { | ||
| color: var(--base-9); |
There was a problem hiding this comment.
only 11 and 12 should be used for text colors, for a11ty contrast reasons.
Please see this documentation for detailed explenation.
Added new component
ToggleWhat's the context?
Addition of new toggle component - closes #43
Rationale behind the change or addition
To have a toggle component that's similar to shadcn toggle
Quality check