Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat]: Toggle component #43

Open
2 tasks done
saran13raj opened this issue Sep 20, 2024 · 8 comments · May be fixed by #45
Open
2 tasks done

[feat]: Toggle component #43

saran13raj opened this issue Sep 20, 2024 · 8 comments · May be fixed by #45
Labels

Comments

@saran13raj
Copy link

Feature description

A Toggle component similar to https://ui.shadcn.com/docs/components/toggle

Affected component/components/documentation

Toggle

Before submitting

  • I've made research efforts and searched the documentation
  • I've searched for existing issues and PRs
Copy link

linear bot commented Sep 20, 2024

@saran13raj
Copy link
Author

saran13raj commented Sep 20, 2024

Hi. I've built the toggle component. You can assign this to me.
I'm unable to raise a PR coz of permission issued with the repo.

Screen.Recording.2024-09-20.at.10.34.48.AM.mov

@silveltman
Copy link
Collaborator

Thank you @saran13raj , looks good!

As for the PR, I believe you can do the following:

  1. Fork the Repo: Click the "Fork" button on the main repository page to create a personal copy.
  2. Clone Your Fork: Clone your forked repo to your local machine with:
  3. Create a Branch: Create a new branch for your changes:
  4. Make Changes: Commit your changes locally.
  5. Push to Fork: Push your branch to your fork:
  6. Open a Pull Request: Go to the original repository and click "Compare & Pull Request" to submit your changes for review.

We can review the PR, without having to add every contributor als a collaborator on the team.

If I'm missing something and there is a better way, please let me know! If not and you need any more help, just ask! 😁

@saran13raj saran13raj linked a pull request Sep 21, 2024 that will close this issue
1 task
@saran13raj
Copy link
Author

@silveltman thanks. I'm with you of creating a PR from forked repo which helps in not add everyone as a contributor.
PR #45 handles this ticket.

@saran13raj
Copy link
Author

@silveltman do you have a dev branch or any similar purposed branch that handles the PRs before prod release?

@silveltman
Copy link
Collaborator

@saran13raj I have created a preview branche in the mean time. This branche will handle PR's before prod release.

Please check the PR for feedback on your code

@silveltman
Copy link
Collaborator

I've decided to remove the preview branche for now. Once we will need it, we can add it. For now it is extra work for not real benefit, since we don't have many PR's yet

@saran13raj
Copy link
Author

I've decided to remove the preview branche for now. Once we will need it, we can add it. For now it is extra work for not real benefit, since we don't have many PR's yet

undestood. And thanks for taking care of it

@silveltman silveltman added the feature label Sep 25, 2024 — with Linear
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants