Fix early return and counting of mismatches with no-calls in barcodes. #48
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #47.
The snippet from barcode matcher was returning None too early if there are
N
s in both expected barcodes and observed barcodes.E.g. When
max_mistmatches == 0
, observed barcodeANAAAA
should matchNNAAAA
, but the snippet below returns None early.To allow for no-calls in barcodes, we have to relax the optimization here and exit early if the number of observed no-calls is greater than the maximum number Ns for any sample barcode plus the maximum allowable number of mismatches.