Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Tokio Command #130

Open
wants to merge 2 commits into
base: dev
Choose a base branch
from

Conversation

petehayes102
Copy link

No description provided.

@igalic
Copy link

igalic commented Jun 17, 2023

and what does that do?

@petehayes102
Copy link
Author

Tokio Command? It's an async version of the std lib, which sits on top of Tokio's runtime.

https://docs.rs/tokio/1.28.2/tokio/process/struct.Command.html

@asomers
Copy link
Contributor

asomers commented Jun 17, 2023

What primitives does it use? I guess it probably uses asynchronous pipe APIs for stdin and stdout. But does it spawn a thread for wait or use kqueue's EVFILT_PROC to detect when the child has exited?

@petehayes102
Copy link
Author

I'm not a Tokio dev, so I don't know what's under the hood. However I do know that Tokio sits on top of Metal I/O, which explicitly supports FreeBSD: https://github.com/tokio-rs/mio.

@fabianfreyer
Copy link
Contributor

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants