Skip to content

Implement cbool for emscripten_set_main_loop to reflect recent emsdk change #130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Implement cbool for emscripten_set_main_loop to reflect recent emsdk change #130

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8905747
Changing type signature of ems_set_main_loop to reflect additiona of …
Feb 19, 2025
631c1dc
Resolve the issue with 'bool' static linking to emscripten?
Feb 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion nico/backends/sdl2.nim
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1829,9 +1829,10 @@ proc getRecordSeconds*(): int =
return 0

when defined(emscripten):
type cbool* {.importc: "bool", nodecl.} = uint8
Copy link

@mratsim mratsim Feb 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
type cbool* {.importc: "bool", nodecl.} = uint8
type cbool* {.importc: "bool", header:"<stdbool>".} = uint8

This will fail if stdbool is not imported, nodecl is used for compiler builtins, though it's possible that the compiler auto-imports stdbool and issues a warning. See https://www.open-std.org/JTC1/SC22/WG14/www/docs/n1256.pdf p253
image

type em_callback_func* = proc() {.cdecl.}
{.push importc.}
proc emscripten_set_main_loop*(f: em_callback_func, fps, simulate_infinite_loop: cint)
proc emscripten_set_main_loop*(f: em_callback_func, fps: cint, simulate_infinite_loop: cbool)
Copy link

@mratsim mratsim Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
proc emscripten_set_main_loop*(f: em_callback_func, fps: cint, simulate_infinite_loop: cbool)
proc emscripten_set_main_loop*(f: em_callback_func, fps: cint, simulate_infinite_loop: bool)

Given that cbool and Nim bool both defer to _Bool it might be okay to reuse Nim bool here and it might be the reason why cbool doesn't exist in Nim.

I leave that choice to the maintainers of the library.

proc emscripten_cancel_main_loop*()
{.pop.}

Expand Down