-
Notifications
You must be signed in to change notification settings - Fork 415
Add support for Python 3.14 and drop EOL 3.9 #1946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It is right to fix the warning in gcsfs (although the timeout would be useful!), or to get the CI job to pass, you can do the same as here for now. |
martindurant
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you comment on why strict=True needs to be added to zip(), but mode="r" (or "rt") needs to be removed from open() when these are both the default values? I would rather not have the big diff if possible.
It's a Ruff rule that triggers for 3.10: https://docs.astral.sh/ruff/rules/zip-without-explicit-strict/ This is from pre-commit. I can revert if you like? If so, we'll need to add B905 to the ignore list.
This is UP015 from running I see UP015 is in the ignore list, I guess running with |
|
Yes, please make it so that strict= is not required, but the mode argument is allowed. The coder should have the freedom to decide what level of explicitness/verbosity is apropriate. |
|
Done! |
Follow on from fsspec/s3fs#993.