Use django bootstrap icon cache #419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 6756067503
💛 - Coveralls |
frcroth
force-pushed
the
use-icon-cache
branch
from
f7448f7 to
13099ed
Compare
|
@frcroth wow, amazing! I would be fine with approving this as a hotfix, but I think it would be nicer to download the icons once in the build step as we tried to avoid CDNs for bootstrap itself and i think it's weird that we then use a CDN for the icons. |
|
Will you approve then? That is very low priority for me. |
|
yes, but I would propose that you don't close the issue then so that we remember that there is something that can be done |
jeriox
approved these changes
Nov 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wow. For my local setup before this change the minimum page load time of the root page was abot 1200ms. With this change (after the first load) it is consistently between 200ms - 400ms. This is huge. 🚀