Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update wagtail to v4.2.4 #413

Merged
merged 13 commits into from
Nov 13, 2023
Merged

update wagtail to v4.2.4 #413

merged 13 commits into from
Nov 13, 2023

Conversation

jeriox
Copy link
Contributor

@jeriox jeriox commented Oct 18, 2023 •
edited
Loading

closes #13 closes #12

the issue found by @Paula-Kli back in the day seems to be gone, entering participants works fine for me although a bit CSS tweaking to bring it back to full width would be good
grafik

@coveralls
Copy link

coveralls commented Oct 18, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 6836100168

  • 12 of 13 (92.31%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.4%) to 74.291%
Changes Missing Coverage Covered Lines Changed/Added Lines %
myhpi/core/markdown/extensions.py 5 6 83.33%
Totals Coverage Status
Change from base Build 6814675352: -0.4%
Covered Lines: 1231
Relevant Lines: 1657
💛 - Coveralls

@jeriox jeriox marked this pull request as ready for review October 18, 2023 19:51
@jeriox jeriox requested a review from frcroth October 18, 2023 19:51
@frcroth frcroth requested a review from Paula-Kli October 19, 2023 08:40
Paula-Kli
Paula-Kli reviewed Oct 22, 2023
View reviewed changes
Copy link
Collaborator

@Paula-Kli Paula-Kli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When having no participants that are recommended I still experience the same problem
image

The question that arises to me is whether that is ever the case in production

frcroth
frcroth reviewed Nov 9, 2023
View reviewed changes
Copy link
Contributor

@frcroth frcroth left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you verify that select2 still works? For me it does not work (throw 404s)?

@jeriox
Copy link
Contributor Author

jeriox commented Nov 10, 2023

Can you verify that select2 still works? For me it does not work (throw 404s)?

works for me

frcroth
frcroth reviewed Nov 12, 2023
View reviewed changes
Copy link
Contributor

@frcroth frcroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jeriox jeriox merged commit f92f893 into main Nov 13, 2023
8 checks passed
@jeriox jeriox deleted the wagtail-4 branch November 13, 2023 14:00
dropforge pushed a commit to dropforge/myHPI that referenced this pull request Nov 21, 2023
@jeriox @Paula-Kli
update wagtail to v4.2.4 (fsr-de#413)
1905392 
Co-authored-by: Paula K <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paula-Kli Paula-Kli Paula-Kli left review comments

@frcroth frcroth frcroth approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Site preview in editing mode Minutes share
4 participants
@jeriox @coveralls @frcroth @Paula-Kli