Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check if we just wrote a DotLambda before deciding on space before parens, fix 3050 #3051

Merged
merged 7 commits into from
May 30, 2024
Merged

Check if we just wrote a DotLambda before deciding on space before parens, fix 3050 #3051

merged 7 commits into from
May 30, 2024

Conversation

dawedawe
Copy link
Member

fixes #3050

github-advanced-security[bot]
github-advanced-security bot found potential problems Feb 27, 2024
View reviewed changes
src/Fantomas.Core/Context.fs Fixed Show fixed Hide fixed
src/Fantomas.Core/Context.fs Fixed Show fixed Hide fixed
nojaf
nojaf requested changes Feb 27, 2024
View reviewed changes
src/Fantomas.Core/Context.fs Outdated Show resolved Hide resolved
@dawedawe dawedawe requested a review from nojaf May 25, 2024 10:36
@dawedawe
instead of using a potentially wrong config for argument nodes, check…
2fe8f49 
… if the node.Expr is an AppSingleParenArg and just be always atomic in that case when writing the FunctionExpr
nojaf
nojaf approved these changes May 30, 2024
View reviewed changes
Copy link
Contributor

@nojaf nojaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this is good enough for now. Will probably cover the most common cases.

nojaf
nojaf reviewed May 30, 2024
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@nojaf nojaf merged commit cb7a8e0 into fsprojects:main May 30, 2024
5 checks passed
@dawedawe dawedawe deleted the fix_3050 branch May 30, 2024 12:15
@dawedawe dawedawe restored the fix_3050 branch June 1, 2024 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojaf nojaf nojaf approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Idempotency problem when _.Property shorthand
2 participants
@dawedawe @nojaf