Use Ionide.Analyzers #2978
Merged
Use Ionide.Analyzers #2978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dawedawe any thoughts why we are not seeing these warnings? |
They are at least here: To me, it seems a bit like the visual behaviour of GitHub is not really deterministic regarding these things. |
nojaf
force-pushed
the
ionide-analyzers
branch
from
b8238bb to
84aaf37
Compare
|
I admit defeat when it comes to Besides that, this is ready for review. |
dawedawe
approved these changes
Nov 15, 2023
josh-degraw
pushed a commit
to josh-degraw/fantomas
that referenced
this pull request
Nov 22, 2023
* Use Ionide.Analyzers * Treat as warnings? * Update Ionide.Analyzers * Bump lock files. * Run both analyzer packages * Try relative paths * Touch file * Delete sarif files * Restore CI build * Use repository root as working directory. * Run both analyzer packages. * Fix Ionide reported problems. * Use AnalyzerFlags * Use FSharp.Analyzers.Build * Revert removal of build-devcontainer. * Add code root * Use AnalyzeFSharpProject * Use array postfix. * Address most analyzer reports * Revert "Address most analyzer reports" This reverts commit d8e93ed. * Update FSharp.Analyzer sdk * Update lock files. * Update packages * Use post fix in signature files. * Use 8.0.100 stable SDK. * Update dev container to 8.0.100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying out https://github.com/ionide/ionide-analyzers