Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to sample CI for an app with SQLProvider #754

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jzsampaio
Copy link

@jzsampaio jzsampaio commented Dec 1, 2021

The linked project includes CI and a Dockerfile for a sample app that uses SQLProvider.

Proposed Changes

The lack of guidelines on how to build and deploy a project w/ SQLProvider has delayed my team from taking SQLProvider to production. We have documented our solution on a sample repo, and we think the community could benefit from it.

Types of changes

What types of changes does your code introduce to SQLProvider?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • Build and tests pass locally
  • I have added tests that prove my fix is effective or that my feature works (if appropriate)
  • I have added necessary documentation (if appropriate)

The linked project configures includes CI and a Dockerfile for a sample app that uses SQLProvider.
@Thorium
Copy link
Member

Thorium commented May 27, 2022

Thanks for the PR and sorry for not merging it, but the statement that "you will need a working database connection" is simply not true. There are multiple options to do CI:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants