[Repo Assist] Perf: optimise mapiAsync with direct enumerator#287
Merged
[Repo Assist] Perf: optimise mapiAsync with direct enumerator#287
mapiAsync with direct enumerator#287Conversation
Replace the asyncSeq-builder + collect implementation of mapiAsync with a new OptimizedMapiAsyncEnumerator that iterates the source directly and maintains the index in a mutable field. This mirrors the existing OptimizedMapAsyncEnumerator and eliminates the collect/For overhead that was previously incurred for every element. Also adds AsyncSeqMapiBenchmarks to measure mapAsync vs mapiAsync vs mapi. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
9 tasks
dsyme
approved these changes
Mar 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 This PR was created by Repo Assist, an automated AI assistant.
Summary
Replaces the
asyncSeq-builder +collectimplementation ofmapiAsyncwith a newOptimizedMapiAsyncEnumeratortype that iterates the source directly and maintains the index in a mutable field.Before (asyncSeq builder path):
After (direct enumerator, same pattern as
mapAsync):Why
mapiAsyncis a core transformation used bymapiandindexed. The previous implementation went throughasyncSeq.For→collect, which allocates a generator per element. The new implementation is a thin enumerator wrapper with no per-element allocation overhead, matching the approach already used bymapAsync,filterAsync, andchooseAsync.Benchmarks added
New
AsyncSeqMapiBenchmarksclass in the benchmarks project measuresmapAsync(baseline),mapiAsync, andmapiat 1K and 10K elements.Test Status
✅ Build succeeded (
netstandard2.0, warnings only — pre-existing).✅ All 321/321 tests passed.