-
-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change the Elmish music player example to use IStorageProvider instea… #407
base: master
Are you sure you want to change the base?
Conversation
Hmm, the only mac I have to try it on is an old Intel iMac, but on that the existing example code crashes with an error about drag regions being invalidated off the main thread when I click the open menu items :-( |
@Numpsy I can test on a modern mac if you want. |
Making it call the open-picker functions through
Ok, it worked on my Ubuntu 22.04 / Gnome / Wayland laptop but it needed an update to a newer version of LibVLCSharp to fix some startup errors about libX11, so I'll see about doing that too. |
…d of the obsoleted OpenFileDialog/OpenFolderDialog
Anyway, this works for me on Windows When in only worked on Windows before. @JaggerJo If you're able to test on a current mac before merging that would be nice (I've seen other bugs where the file dialog behaviour got changed in macOS updates, so may as well try even though it's only an example I think) |
…d of the obsoleted OpenFileDialog/OpenFolderDialog
As it stands, there are a bunch of build warnings about using the deprecated file / folder picker APIs, and this is an attempt to sort those by changing it to use the newer IStorageProvider interfaces.
Notes:
populateFromDirectory
mapping back into paths to avoid further changes for now.