Find license identifiers in comments with ASCII art frames

[pietroalbini]

The Rust project is working to adopt REUSE to annotate licenses, but when working on the initial implementation I stumbled on #343. The Rust repository has LLVM as one of its submodules, and REUSE currently errors out on some of the LLVM comments:

reuse._util - ERROR - Could not parse 'Apache-2.0 WITH LLVM-exception                    *|'
reuse.project - ERROR - 'src/llvm-project/lldb/source/Plugins/Plugins.def.in' holds an SPDX expression that cannot be parsed, skipping the file                                                                      

As #343 correctly pointed out, the problem is that LLVM uses ASCII art "frames" for those code comments, like:

/***********************************************************\
|* SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception *|
\***********************************************************/

The solution I came up with is to implement generic handling for these kinds of ASCII art, even in cases where the multiline delimiter (in this case *) is not present. When there are some non-whitespace chars before SPDX-License-Identifier, the new code tries to strip the reverse of them from the end of the line. That correctly handles LLVM comments, but also any other ASCII art frame that's symmetric.

Fixes #343

[carmenbianca]

Looks good to me. I'm not sure if the case this covers is a good general case, but we can cross that bridge when someone else's ASCII art breaks.

Thanks for the PR! Please make sure to add a change log entry, and add yourself to AUTHORS.rst if you want.

[pietroalbini]

Thanks for the quick review! I should've addressed everything.

[mxmehl]

Thanks, that's a clever approach a nice first step!

[pietroalbini]

Hey all, thanks for the reviews! What are the next steps to get this merged and released?

[carmenbianca]

@pietroalbini Sorry for the delay. This gets merged now for the next release, which shouldn't be too long away.