fix: dont dump detailled map of the target if the target is a map

Signed-off-by: francois samin <[email protected]>
fsamin · May 2, 2022 · 1fe65a0 · 1fe65a0
1 parent db680ab
commit 1fe65a0
Show file tree

Hide file tree

Showing 2 changed files with 20 additions and 2 deletions.
diff --git a/dump_test.go b/dump_test.go
@@ -694,6 +694,22 @@ func Test_DumpTime(t *testing.T) {
 
 }
 
+func Test_DumpMap(t *testing.T) {
+	m := map[string]interface{}{
+		"string": "foobar",
+	}
+	e := dump.NewDefaultEncoder()
+	e.ExtraFields.Len = true
+	e.ExtraFields.Type = true
+	e.ExtraFields.DetailedStruct = true
+	e.ExtraFields.DetailedMap = true
+	e.ExtraFields.DetailedArray = true
+	result, err := e.ToStringMap(m)
+	require.NoError(t, err)
+	t.Log(result)
+	require.Len(t, result, 3)
+}
+
 func Test_DumpTimeWithDetailledStruct(t *testing.T) {
 	m := map[string]interface{}{
 		"string": "foobar",

diff --git a/encoder.go b/encoder.go
@@ -263,8 +263,10 @@ func (e *Encoder) fDumpMap(w map[string]interface{}, i interface{}, roots []stri
 		w[nodeLenFormatted] = lenKeys
 	}
 	if e.ExtraFields.DetailedMap {
-		structKey := strings.Join(sliceFormat(roots, e.Formatters), e.Separator)
-		w[structKey] = i
+		if len(roots) != 0 {
+			structKey := strings.Join(sliceFormat(roots, e.Formatters), e.Separator)
+			w[structKey] = i
+		}
 	}
 	return nil
 }