Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix various scanner issues #1305

Merged
merged 4 commits into from
Oct 19, 2023
Merged

Fix various scanner issues #1305

merged 4 commits into from
Oct 19, 2023

Conversation

nguyentvan7
Copy link
Collaborator

@nguyentvan7 nguyentvan7 commented Oct 19, 2023

Describe your changes

Bump Tesseract version. Fix a couple of scanning issues. Use a custom trained model for Tesseract.

Issue or discord link

Testing/validation

See issues for test screenshots

I tested performance of default vs fast model vs best model (taken from InventoryKamera github)
image
image
image

Default is fastest, but not by much compared to fast model. The fast model has accurate feather level 20 detection. The best model is the slowest and also fails to detect the accurate mainstat for feathers. So I opted for using the fast model

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code, in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • Ran yarn run mini-ci locally to validate format + lint.
  • If there were format issues, I ran nx format write to resolve them automatically.

@nguyentvan7 nguyentvan7 requested a review from frzyc October 19, 2023 01:41
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

[gi-frontend] [Thu Oct 19 01:42:03 UTC 2023] - Building version

[sr-frontend] [Thu Oct 19 01:42:08 UTC 2023] - Building version

[frontend] [Thu Oct 19 01:42:43 UTC 2023] - Building version

[sr-frontend] [Thu Oct 19 01:43:23 UTC 2023] - Deployed 38f62a2 to https://genshin-optimizer-prs.github.io/pr/1305/sr-frontend (Takes 3-5 minutes after this completes to be available)

[gi-frontend] [Thu Oct 19 01:43:25 UTC 2023] - Building version d587df7

[sr-frontend] [Thu Oct 19 01:43:39 UTC 2023] - Building version d587df7

[frontend] [Thu Oct 19 01:43:40 UTC 2023] - Building version d587df7

[sr-frontend] [Thu Oct 19 01:45:03 UTC 2023] - Deployed d587df7 to https://genshin-optimizer-prs.github.io/pr/1305/sr-frontend (Takes 3-5 minutes after this completes to be available)

[gi-frontend] [Thu Oct 19 01:46:39 UTC 2023] - Deployed d587df7 to https://genshin-optimizer-prs.github.io/pr/1305/gi-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu Oct 19 01:48:30 UTC 2023] - Deployed 38f62a2 to https://genshin-optimizer-prs.github.io/pr/1305/frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu Oct 19 15:30:45 UTC 2023] - Building version d587df7

[frontend] [Thu Oct 19 15:35:51 UTC 2023] - Deployed d587df7 to https://genshin-optimizer-prs.github.io/pr/1305/frontend (Takes 3-5 minutes after this completes to be available)

[Thu Oct 19 18:14:57 UTC 2023] - Deleted deployment

@nguyentvan7 nguyentvan7 merged commit a79bc03 into master Oct 19, 2023
@nguyentvan7 nguyentvan7 deleted the van/fixScannerIssues branch October 19, 2023 18:14
@frzyc frzyc added the hacktoberfest-accepted For hacktoberfest label Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted For hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feathers with 311 atk scan incorrectly Nymph circlet scans incorrectly Bump tesseractjs version
2 participants