Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Tesseract version #1302

Closed
wants to merge 1 commit into from
Closed

Bump Tesseract version #1302

wants to merge 1 commit into from

Conversation

nguyentvan7
Copy link
Collaborator

@nguyentvan7 nguyentvan7 commented Oct 19, 2023

Describe your changes

Bump Tesseract.js version to 5.x. This fixes a bug where the scanner did not work in iOS 17. In my limited testing, it also seems to be faster even on a dev build compared to the prod scanner.

Issue or discord link

Testing/validation

Tested by scanning artifact images

Checklist before requesting a review (leave this PR as draft if any part of this list is not done.)

  • I have commented my code, in hard-to understand areas.
  • I have made corresponding changes to README or wiki.
  • For front-end changes, I have updated the corresponding English translations.
  • Ran yarn run mini-ci locally to validate format + lint.
  • If there were format issues, I ran nx format write to resolve them automatically.

@nguyentvan7 nguyentvan7 requested a review from frzyc October 19, 2023 00:21
@github-actions
Copy link
Contributor

github-actions bot commented Oct 19, 2023

[frontend] [Thu Oct 19 00:22:56 UTC 2023] - Building version

[gi-frontend] [Thu Oct 19 00:23:04 UTC 2023] - Building version

[sr-frontend] [Thu Oct 19 00:23:14 UTC 2023] - Building version

[sr-frontend] [Thu Oct 19 00:24:33 UTC 2023] - Deployed 38f62a2 to https://genshin-optimizer-prs.github.io/pr/1302/sr-frontend (Takes 3-5 minutes after this completes to be available)

[gi-frontend] [Thu Oct 19 00:26:23 UTC 2023] - Deployed 38f62a2 to https://genshin-optimizer-prs.github.io/pr/1302/gi-frontend (Takes 3-5 minutes after this completes to be available)

[frontend] [Thu Oct 19 00:27:13 UTC 2023] - Deployed 38f62a2 to https://genshin-optimizer-prs.github.io/pr/1302/frontend (Takes 3-5 minutes after this completes to be available)

[Thu Oct 19 17:47:38 UTC 2023] - Deleted deployment

@frzyc frzyc added the fix ASAP Needs to be fixed as soon as possible label Oct 19, 2023
@frzyc frzyc added the hacktoberfest-accepted For hacktoberfest label Oct 23, 2023
@nguyentvan7 nguyentvan7 deleted the van/updateTesseract branch January 6, 2024 02:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix ASAP Needs to be fixed as soon as possible hacktoberfest-accepted For hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bump tesseractjs version
2 participants