Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #108 #109

Merged
merged 1 commit into from
Dec 11, 2024
Merged

Fix #108 #109

merged 1 commit into from
Dec 11, 2024

Conversation

jukefr
Copy link

@jukefr jukefr commented Dec 11, 2024 •
edited
Loading

Fix #108

@jukefr
fix: Use self.rev first, otherwise fallback on self.dirtyRev, otherwi…
8c099c0 
…se fallback on hardcoded value for nix flake version
@froz42 froz42 self-requested a review December 11, 2024 09:55
@froz42 froz42 self-assigned this Dec 11, 2024
@froz42 froz42 added enhancement New feature or request bug Something isn't working and removed enhancement New feature or request labels Dec 11, 2024
froz42
froz42 approved these changes Dec 11, 2024
View reviewed changes
Copy link
Owner

@froz42 froz42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for your contribution, I'm merging it.

@froz42 froz42 merged commit c023b90 into froz42:main Dec 11, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@froz42 froz42 froz42 approved these changes

Assignees

@froz42 froz42

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Usage of dirtyRev in the flake makes it not very user friendly / usable
2 participants
@jukefr @froz42